Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NutanixMachineConfig crd and eksa-components manifest file #8846

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Oct 14, 2024

Description of changes:
GPU support for Nutanix was added in #8745. This PR updates the NutanixMachineConfig CRD file and eksa-components manifest file by running make generate-manifests and make release-manifests to add GPU support for Nutanix.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sp1999
Copy link
Member Author

sp1999 commented Oct 14, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.77%. Comparing base (4d1408c) to head (3db0e7c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8846      +/-   ##
==========================================
+ Coverage   73.74%   73.77%   +0.02%     
==========================================
  Files         578      578              
  Lines       36788    36832      +44     
==========================================
+ Hits        27130    27173      +43     
- Misses       7928     7929       +1     
  Partials     1730     1730              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot merged commit bd90ca9 into aws:main Oct 14, 2024
8 checks passed
@sp1999 sp1999 deleted the update-crds-and-manifest branch October 14, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants